feat: Add RBAC DB source #5756
Open
feat: Add RBAC DB source #5756
+233
−224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregataa
added
the
skip:changelog
github-actions
bot
added
size:L
fregataa
force-pushed
the
feat/add-rbac-db-source
branch
from
4f51346 to
0f600c4
Compare
fregataa
force-pushed
the
feat/add-processors-based-on-action-types
branch
from
bfdd80a to
2cf1a22
Compare
fregataa
force-pushed
the
feat/add-rbac-db-source
branch
2 times, most recently
from
3c9040b to
8ec6b57
Compare
| from ...models.utils import ExtendedAsyncSAEngine | ||
|
|
||
|
|
||
| class PermissionControllerDBSource: |
There was a problem hiding this comment.
It doesn't seem good that the word "controller" is included in the source.
Comment on lines
69
to
71
| role_row = await self._get_role(data.id, db_session) | ||
| if role_row is None: | ||
| raise ObjectNotFound(f"Role with ID {data.id} does not exist.") |
There was a problem hiding this comment.
It would be better if you returned it non-Optional from the moment you read it in _get_role.
Comment on lines
+101
to
+119
| j = ( | ||
| sa.join( | ||
| RoleRow, | ||
| UserRoleRow, | ||
| RoleRow.id == UserRoleRow.role_id, | ||
| ) | ||
| .join( | ||
| ObjectPermissionRow, | ||
| RoleRow.id == ObjectPermissionRow.role_id, | ||
| ) | ||
| .join( | ||
| PermissionGroupRow, | ||
| RoleRow.id == PermissionGroupRow.role_id, | ||
| ) | ||
| .join( | ||
| PermissionRow, | ||
| PermissionGroupRow.id == PermissionRow.permission_group_id, | ||
| ) | ||
| ) |
fregataa
force-pushed
the
feat/add-processors-based-on-action-types
branch
from
2cf1a22 to
4db5743
Compare
fregataa
force-pushed
the
feat/add-rbac-db-source
branch
from
8ec6b57 to
bfe9e1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: (if applicable)
ai.backend.testdocsdirectory